[ 
https://issues.apache.org/jira/browse/PDFBOX-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066259#comment-15066259
 ] 

Maciej Woźniak commented on PDFBOX-3163:
----------------------------------------

The method createFromFileByExtension is used in createFromFile(String, 
PDDocument) (PDImageXObject.java), now it could be changed to 
createFromFileByContent.
createFromFile(String, PDDocument) is used in AddImageToPDF, ImageToPDF, 
RubberStampWithImage.

> PDImageXObject.createFromFile should relies on header bytes
> -----------------------------------------------------------
>
>                 Key: PDFBOX-3163
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3163
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 2.0.0
>            Reporter: Benjamin Gamard
>         Attachments: 3163.patch
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> PDImageXObject.createFromFile currently relies on file extension to select 
> the correct factory.
> Often, file extension is not set or not correct.
> It should be better to use the first bytes.
> I did something similar here if it can helps: 
> https://github.com/sismics/docs/blob/master/docs-core/src/main/java/com/sismics/util/mime/MimeTypeUtil.java#L26



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to