[ 
https://issues.apache.org/jira/browse/PDFBOX-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273677#comment-15273677
 ] 

Petras commented on PDFBOX-3322:
--------------------------------

Only in the updated example the options are closed in the place it is created. 
As the options may be closed ONLY after _doc.saveIncremental(fis, fos)_ is 
invoked (the action unrelated to SignatureOptions construction), the logic 
which does the PDF saving and closing must also somehow obtain and close the 
options as well. I can hardly remember any other structure in PDModel 
architecture, which would require separate closing beside closing PDDocument. 
Its really confusing.

> Warning "You did not close a PDF Document" when visual signature is added
> -------------------------------------------------------------------------
>
>                 Key: PDFBOX-3322
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3322
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel, Signing
>    Affects Versions: 1.8.11
>            Reporter: Petras
>            Assignee: Tilman Hausherr
>              Labels: signature
>             Fix For: 1.8.13
>
>         Attachments: PDFBOX_3322_VisualSignatureClosing.patch
>
>
> When visual signature is added, warning "You did not close a PDF Document" is 
> added to the output log. It appears, that _VisualSignatureParser_ creates an 
> instance of _COSDocument_ and later is held by _SignatureOptions_, but for 
> this instance the {{#close()}} method is never called, which results to that 
> warning reported by its {{#finalize()}} method.
> Probably it should by closed by _PDDocument_ when used after signing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to