[ 
https://issues.apache.org/jira/browse/PDFBOX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295809#comment-15295809
 ] 

Carlos Cabral commented on PDFBOX-3355:
---------------------------------------

Hi [~tilman], thank you very much for the quick fix. I tested your new logic 
and it solved the bug. 


> PDPageLabels.getLabelsByPageIndices() returns Uppercase letters for style a
> ---------------------------------------------------------------------------
>
>                 Key: PDFBOX-3355
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3355
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 1.8.12, 1.8.13, 2.0.1, 2.0.2, 2.1.0
>         Environment: Windows Computer
>            Reporter: Carlos Cabral
>            Assignee: Tilman Hausherr
>            Priority: Trivial
>              Labels: easyfix
>             Fix For: 1.8.13, 2.0.2, 2.1.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> For the style 'a' the Method getLabelsByPageIndices returns uppercase due to 
> the method LabelGenerator.makeLetterLabel always returns uppercase. Then the 
> method LabelGenerator.getNumber shoule be changed from:
> {code}
> } else if (PDPageLabelRange.STYLE_LETTERS_LOWER.equals(style)) {
>     return makeLetterLabel(pageIndex);
> } else if (PDPageLabelRange.STYLE_LETTERS_UPPER.equals(style)) {
>     return makeLetterLabel(pageIndex).toUpperCase();
> }
> {code}
> to: 
> {code}
> } else if (PDPageLabelRange.STYLE_LETTERS_LOWER.equals(style)) {
>     return makeLetterLabel(pageIndex).toLowerCase();
> } else if (PDPageLabelRange.STYLE_LETTERS_UPPER.equals(style)) {
>     return makeLetterLabel(pageIndex);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to