[ 
https://issues.apache.org/jira/browse/PDFBOX-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433207#comment-15433207
 ] 

Maruan Sahyoun edited comment on PDFBOX-3471 at 8/23/16 5:21 PM:
-----------------------------------------------------------------

[~abyss] Although the patch fixes the issue with the comments the main issue is 
removing specific nodes in the method {{removeComments}}. While the elements 
are removed the indices are no longer valid which misses certain nodes. Could 
you/are you willing to propose a patch for that as because of the issue in that 
method other cases for removal will be missed too. I'd still go for 
{{dbFactory.setIgnoringComments(true);}} in addition to that.


was (Author: msahyoun):
[~abyss] Although the patch fixes the issue with the comments the main issue is 
removing specific nodes in the method {{removeComments}}. While the elements 
are removed the indices are no longer valid which misses certain nodes. Could 
you/are you willing to propose a patch for that?

> XMP parsing fails if XMP contain comments
> -----------------------------------------
>
>                 Key: PDFBOX-3471
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3471
>             Project: PDFBox
>          Issue Type: Bug
>          Components: XmpBox
>    Affects Versions: 2.0.2
>            Reporter: Petras
>         Attachments: PDFBOX-3471_XmpParsingIgnoringComments.patch
>
>
> DomXmpParser parser fails with such correct XMP:
> {code:xml}
> <?xpacket begin="" id="W5M0MpCehiHzreSzNTczkc9d"?>
> <x:xmpmeta xmlns:x="adobe:ns:meta/" x:xmptk="Adobe XMP Core 5.1.0-jc003">
>     <!-- PDF/A standarto versija (1 ar 2) ir suderinamumo lygmuo (A, B ar U) 
> -->
>     <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#";>
>         <rdf:Description rdf:about = ""
>                          xmlns:pdfaid = "http://www.aiim.org/pdfa/ns/id/";>
>             <pdfaid:part>1</pdfaid:part>
>             <pdfaid:conformance>B</pdfaid:conformance>
>         </rdf:Description>
>     </rdf:RDF>
> </x:xmpmeta>
> <?xpacket end="w"?>
> {code}
> DomXmpParser finds comment node and fails:
> {code}
> org.apache.xmpbox.xml.XmpParsingException: More than one element found in 
> x:xmpmeta
>       at 
> org.apache.xmpbox.xml.DomXmpParser.findDescriptionsParent(DomXmpParser.java:750)
>       at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:183)
>       at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:111)
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to