[
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491258#comment-15491258
]
Tilman Hausherr commented on PDFBOX-2852:
-----------------------------------------
Ok, you've both persuaded me.
One thing I'm not persuaded is the first change in the stringbuilder patch, it
creates a temporary list to fill another.
{code}
- for (int q = start; q <= p; ++q)
- {
- contour.add(points[q]);
- }
+ contour.addAll(Arrays.asList(points).subList(start, p + 1));
{code}
> Improve code quality (2)
> ------------------------
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: PDNameTreeNode.java.patch, XMPSchema.java.patch,
> explicit_array_creation.patch, fix_javadoc.patch, foreach.patch,
> semicolon.patch, stringbuilder.patch, unnecessary_type_casting.patch,
> unused_imports.patch, winansiencoding.patch, winansiencoding2.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
