[ 
https://issues.apache.org/jira/browse/PDFBOX-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534323#comment-15534323
 ] 

John Hewson edited comment on PDFBOX-3300 at 9/29/16 10:51 PM:
---------------------------------------------------------------

The JVM is likely to just optimize away those ArrayLists completely. Remember, 
small, short-lived allocations perform very well with GC. Unless you have a 
concrete performance issue, I'd recommend designing a clean API first.

You seem to be saying that you've tightly coupled CmapSubtable with 
PDCIDFontType2Embedder, but this isn't a desirable thing. CmapSubtable is a 
public API and needs to expose something clean and general purpose - 
irrespective of what PDCIDFontType2Embedder wants to then do with that result. 
You're implying that it's a just a private API... but it's not.

Again, this method doesn't even necessarily return Unicode characters.


was (Author: jahewson):
The JVM is likely to just optimize away those ArrayLists completely. Remember, 
small, short-lived allocations perform very well with GC.

You seem to be saying that you've tightly coupled CmapSubtable with 
PDCIDFontType2Embedder, but this isn't a desirable thing. CmapSubtable is a 
public API and needs to expose something clean and general purpose - 
irrespective of what PDCIDFontType2Embedder wants to then do with that result. 
You're implying that it's a just a private API... but it's not.

Again, this method doesn't even necessarily return Unicode characters.

> Space rendered as missing glyph
> -------------------------------
>
>                 Key: PDFBOX-3300
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3300
>             Project: PDFBox
>          Issue Type: Bug
>          Components: FontBox, Rendering
>    Affects Versions: 2.0.0, 2.0.1, 2.1.0
>            Reporter: Tilman Hausherr
>            Assignee: Andreas Lehmkühler
>             Fix For: 2.0.4, 2.1.0
>
>         Attachments: PDFBOX-3300-p1.jpg, PDFBOX-3300-p1.pdf, 
> PDFBOX-3300-patch.txt, PDFBOX_3300.patch
>
>
> In this file, the spaces are rendered with a "?".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to