[
https://issues.apache.org/jira/browse/PDFBOX-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223637#comment-16223637
]
Hossam Hazem edited comment on PDFBOX-3971 at 10/28/17 6:01 PM:
----------------------------------------------------------------
yes, you are right. removed removeByteArrayFromCOSArray, and replaced it and
the for loop in removeKeyUsage with array.remove
and I need to add a check for null on the input before doing _new
COSString(keyUsageExtension)_
-----------
added the patch.
for the null check, according to PDSignature
{code:java}
void setContents(byte[] bytes)
{code}
it doesn't check it, it is logical to throw NPE and not to suppress it so left
it unchecked.
was (Author: hossam-hazem):
yes, you are right. removed removeByteArrayFromCOSArray, and replaced it and
the for loop in removeKeyUsage with array.remove
and I need to add a check for null on the input before doing _new
COSString(keyUsageExtension)_
added the patch.
for the null check, according to PDSignature
{code:java}
void setContents(byte[] bytes)
{code}
it doesn't check it, it is logical to throw NPE and not to suppress it so left
it unchecked.
> Add Certificate Dictionary to seed value in signature field
> -----------------------------------------------------------
>
> Key: PDFBOX-3971
> URL: https://issues.apache.org/jira/browse/PDFBOX-3971
> Project: PDFBox
> Issue Type: Improvement
> Components: Signing
> Reporter: Hossam Hazem
> Assignee: Tilman Hausherr
> Labels: documentation, features, newbie, patch, test
> Fix For: 2.0.8, 3.0.0
>
> Attachments: COSName.patch, PDSeedValue.patch,
> PDSeedValueCertificate.java, PDSeedValueCertificate.patch
>
>
> This dictionary is important as it gives the ability to put certificate
> constraints on a signature field, like if you want signatures that are signed
> by a specific issuer or authority to only be used in a field.
> currently tested Issuer constraint and it worked, acrobat reader ignores
> other certificates and only allow the issuer given to sign the field.
> documentation is not complete waiting for the initial acceptance to complete.
> new class PDSeedValueCertificate is added which refers to this certificate.
> PDSeedValue is modified to add the new dictionary.
> COSName is modified to add the new pdf names that are included in the
> dictionary.
> reference for this dictionary can be found in PDF reference 1.7 section
> 12.7.4.5 table 235 page 457 in here
> http://www.adobe.com/content/dam/acom/en/devnet/pdf/PDF32000_2008.pdf
> or chapter 8 table 8.84 page 700 in here
> http://archimedespalimpsest.net/Documents/External/pdf_reference_1-7.pdf
> and in here
> https://www.adobe.com/devnet-docs/acrobatetk/tools/DigSig/Acrobat_DigitalSignatures_in_PDF.pdf
> this is my first contribution, hope everything goes well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
