[
https://issues.apache.org/jira/browse/PDFBOX-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280499#comment-16280499
]
Tilman Hausherr commented on PDFBOX-4020:
-----------------------------------------
Heh heh, thanks to the last edit one comment less...
- processTimestamping() is public - is this ever called from outside? I'm
asking because you're using some variables like "document" that may be
uninitialized.
- processTimestamping still opens the file twice. It would be faster to call
{{IOUtils.toByteArray(fis)}} and work with that one.
{{PDSignature.getContents()}} can accept a byte array as input.
- please run a complete build with the tests, one fails. The method that fails
should be adjusted to pass the URL.
> Into existing signature embedded signed timestamp for validation
> ----------------------------------------------------------------
>
> Key: PDFBOX-4020
> URL: https://issues.apache.org/jira/browse/PDFBOX-4020
> Project: PDFBox
> Issue Type: Improvement
> Components: Signing
> Affects Versions: 2.0.8
> Reporter: Alexis Suter
> Attachments: SignatureValidation_Embedded_Timestamping.java.patch,
> SignatureValidation_Embedded_Timestamping_v0.2.java.patch,
> SignatureValidation_Embedded_Timestamping_v0.3.java.patch, signed_ts_ocsp.pdf
>
>
> I would like to contribute a new example for embedded Timestamping.
> The Timestamp is beeing embedded into the existing Signature (which has so be
> prepared big enough for it). So that the document does not get changed.
> This Step is a preparation for the LTV and includes some reorganisation for
> Validation-Purposes.
> I am still working on embedding the OCSP-Data, wich will take a bit longer.
> For that I have excluded and commented out the Code for it, to avoid
> confusion.
> Possible Usage:
> {code:java}
> exec:java -X
> -Dexec.mainClass="org.apache.pdfbox.examples.signature.validation.CreateEmbeddedValidation"
> -Dexec.args="${infile} -tsa ${tsa}"
> {code}
> CreateSignature has been changed to add SignatureOptions, where we can choose
> the size of the signature.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
