[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356827#comment-16356827
 ] 

Maruan Sahyoun commented on PDFBOX-4071:
----------------------------------------

[~tilman] I'd like to start working on avoiding some {{ClassCastException}} in 
the packages I'm mainly contributing too (there are some potential candidates). 
Before doing so a quick question. Currently the {{ClassCastException}} is an 
indicator for a malformed PDF is most cases. If we avoid it by checking the 
return type via instanceof before doing the cast this might be unnoticed. Is 
that OK or shall we provide some kind of information e.g. log output (would 
suggest info or below) like ''Expected X but got Y'.
WDYT?

> Improve code quality (3)
> ------------------------
>
>                 Key: PDFBOX-4071
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4071
>             Project: PDFBox
>          Issue Type: Task
>    Affects Versions: 2.0.8
>            Reporter: Tilman Hausherr
>            Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to