[ 
https://issues.apache.org/jira/browse/PDFBOX-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368380#comment-16368380
 ] 

Tilman Hausherr edited comment on PDFBOX-4114 at 2/19/18 5:42 PM:
------------------------------------------------------------------

I need some time to review the effects with different jdks and different 
configurations (KCMS / LCMS). I ran a rendering diff test and the rendering of 
8 files of 1000 are different. One of them was known to have bad rendering 
(PDFBOX-2917) and that looks good now, so this is getting interesting :)
 - eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf: p13 better
 - gs-bugzilla691182.pdf: slight difference
 - immo-kurier_arsenal_93x62.pdf: slight difference
 - PDFBOX-1274.pdf: much better
 - PDFBOX-2917.pdf ("the pepsi bottle"): much better
 - PDFBOX-3494.pdf: better
 - PDFBOX-3802: better
 - PDFBOX-4022-slow.pdf: slight difference

Shouldn't {{fixProfile}} be called *after* {{is_sRGB}}?

And what if java has fixed this bug in some later version - wouldn't your fix 
"undo" it?

Your parameter is named "cmykProfile" but ICC profiles don't have to be CMYK. 
There can be with 3 colors or gray (PDFBOX-1274).

Please edit your question to add what you've found "across internet", i.e. put 
a link or two there.


was (Author: tilman):
I need some time to review the effects with different jdks and different 
configurations (KCMS / LCMS). I ran a rendering diff test and the rendering of 
7 files of 1000 are different. One of them was known to have bad rendering 
(PDFBOX-2917) and that looks good now, so this is getting interesting :)

- eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf: p13 better
- gs-bugzilla691182.pdf: slight difference
- immo-kurier_arsenal_93x62.pdf: slight difference
- PDFBOX-1274.pdf: much better
- PDFBOX-2917.pdf ("the pepsi bottle"): much better
- PDFBOX-3494.pdf: better
- PDFBOX-4022-slow.pdf: slight difference

Shouldn't {{fixProfile}} be called *after* {{is_sRGB}}?

And what if java has fixed this bug in some later version - wouldn't your fix 
"undo" it?

Your parameter is named "cmykProfile" but ICC profiles don't have to be CMYK. 
There can be with 3 colors or gray (PDFBOX-1274).

Please edit your question to add what you've found "across internet", i.e. put 
a link or two there.

> ICCBased color spaces wrong color output
> ----------------------------------------
>
>                 Key: PDFBOX-4114
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4114
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel, Rendering
>    Affects Versions: 2.0.8
>            Reporter: Michael Vakulich
>            Priority: Major
>             Fix For: 2.0.9, 3.0.0 PDFBox
>
>         Attachments: ICCBased_updated.patch, compare.jpg, highResPdf-1.jpg, 
> highResPdf.pdf
>
>
> When rendering page with embedded ICC_profile (DeviceCMYK) it has a wrong 
> colors, like semitransparent white plane covering the page
>  See the render output
> Tried patches suggested here
> [https://forums.adobe.com/thread/1914790]
> https://github.com/haraldk/TwelveMonkeys/blob/master/imageio/imageio-jpeg/src/main/java/com/twelvemonkeys/imageio/plugins/jpeg/JPEGImageReader.java
> and trying one by one found that problem is connected to profileClass
> Here is the one of proposed patches I've found and which worked for me
>  Please review proposed patch



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to