[ 
https://issues.apache.org/jira/browse/PDFBOX-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375321#comment-16375321
 ] 

Tilman Hausherr commented on PDFBOX-4117:
-----------------------------------------

As expected, Sonar doesn't like it and here's the reason: "While null is 
technically a valid Boolean value, that fact, and the distinction between 
Boolean and boolean is easy to forget. So returning null from a Boolean method 
is likely to cause problems with callers' code."

And yes, a developer who calls {{shouldOpenInNewWindow()}} without looking at 
the javadoc would get an NPE soon.

> Implement GoToE action-type
> ---------------------------
>
>                 Key: PDFBOX-4117
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4117
>             Project: PDFBox
>          Issue Type: New Feature
>          Components: AcroForm
>    Affects Versions: 1.8.13, 2.0.8
>            Reporter: Gilad Denneboom
>            Assignee: Tilman Hausherr
>            Priority: Major
>         Attachments: Sample GoToE Link.pdf
>
>
> One of the major Action Types is not implemented in any version of PDFBox, 
> and I believe it should be. I'm referring to "Embedded Go-To Actions" 
> (defined under 12.6.4.4 in PDF 32000-1:2008), which allows a link to open an 
> attached file. Currently, such "GoToE" actions are interpreted as "null" by 
> PDFBox, which is not ideal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to