[ 
https://issues.apache.org/jira/browse/PDFBOX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384035#comment-16384035
 ] 

Tilman Hausherr commented on PDFBOX-4138:
-----------------------------------------

Heh heh, either the variable is badly named or the code is wrong. I ran my 
tests with the change and the 003422.pdf from {color:#333333}PDFBOX-3110 is 
different, and the result looks weird: "VOLUME 77 I E W L E T T E R S 12 AUGUST 
1996" is on top now, before it was "VOLUME 77, NUMBER 7 P H Y S I C A L R E V I 
E W L E T T E R S 12 AUGUST 1996" which makes more sense{color}. Or own test 
file shows no difference. Do you have a file yourself that didn't extract the 
way you expected? What made you look at that code?

> PDFTextStripper: error in a comparison
> --------------------------------------
>
>                 Key: PDFBOX-4138
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4138
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Text extraction
>    Affects Versions: 2.0.8
>            Reporter: Julien FĂ©rard
>            Priority: Minor
>
> This is very simple. Maybe I'm wrong, but in PdfTextStripper, l. 844
>  
> [https://github.com/apache/pdfbox/blob/0e07344c0e3a932f0ca346f7cac4700882c67b5d/pdfbox/src/main/java/org/apache/pdfbox/text/PDFTextStripper.java#L844]
>  * You want to check if the pos is on the left *and* above the rectangle 
> (this is better than just on the left or just above);
>  * The name of the variable contains "LeftAndAbove".
> ...and the code contains a `||` (or).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to