[
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394589#comment-16394589
]
Maruan Sahyoun commented on PDFBOX-4071:
----------------------------------------
[~tilman] [~lehmi] Could you take a look at the following code from
{{FileSystemProvide}} L296
{code}
File file = getDiskCacheFile();
try
{
writer = new BufferedWriter(new FileWriter(file));
}
catch (SecurityException e)
{
LOG.debug("Couldn't create writer for " +
file.getAbsolutePath(), e);
return;
}
{code}
Shouldn't the line {{File file = getDiskCacheFile();}} be within the {{try}} as
{{getDiskCacheFile()}} is the method which might throw a {{SecurityException}}
Would change it and also use {{try-with}} but haven't dealt with this part of
the code before. If you agree we should add that to {{2.0.9}} (without the
{{try-with}} part obviously)
> Improve code quality (3)
> ------------------------
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.8
> Reporter: Tilman Hausherr
> Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the
> [SonarQube
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
> hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
