[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394660#comment-16394660
 ] 

Andreas Lehmkühler commented on PDFBOX-4071:
--------------------------------------------

bq. Shouldn't the line File file = getDiskCacheFile(); be within the try as 
getDiskCacheFile() is the method which might throw a SecurityException
Yes, but the other line has to remain within try/catch as  {{new FileWriter}} 
might throw that exception as well

> Improve code quality (3)
> ------------------------
>
>                 Key: PDFBOX-4071
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4071
>             Project: PDFBox
>          Issue Type: Task
>    Affects Versions: 2.0.8
>            Reporter: Tilman Hausherr
>            Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to