[ 
https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405082#comment-16405082
 ] 

Maruan Sahyoun edited comment on PDFBOX-4158 at 3/19/18 4:34 PM:
-----------------------------------------------------------------

My proposal would be to capture the first exception, log all exceptions and 
rethrow the captured one at the end as {{IOException}} is already declared to 
be thrown by the methods. I think there is no need to keep all of them and 
chain them together. WDYT?  If you're fine with that could you provide a patch 
along that approach?  

Would do the logging at WARN level.


was (Author: msahyoun):
My proposal would be to capture the first exception, log all exceptions and 
rethrow the captured one at the end as {{IOException}} is already declared to 
be thrown by the methods. I think there is no need to keep all of them and 
chain them together. WDYT?  If you're fine with that could you provide a patch 
along that approach?  

> COSDocument and PDFMerger may not close all IO resources if closing of one 
> fails
> --------------------------------------------------------------------------------
>
>                 Key: PDFBOX-4158
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4158
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 2.0.4, 2.0.9, 3.0.0 PDFBox
>            Reporter: Maruan Sahyoun
>            Priority: Minor
>         Attachments: BiggestObjectAllocationGraph.png, BiggestObjectList.png
>
>
> As observed on the users mailing list  {{COSDocument.close}} and 
> {{PDFMergerUtility.mergeDocuments}} might not close all IO resources if 
> closing of one of the resources fails



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to