[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406434#comment-16406434 ]
Maruan Sahyoun commented on PDFBOX-4071: ---------------------------------------- I've move the Sonar related annotation in {{GlyphSubstitutionTable}} to the method. Maybe it's better and clearer instead of reading into unused variables to skip the bytes we are not interested in. [~lehmi][~tilman] WDYT? > Improve code quality (3) > ------------------------ > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task > Affects Versions: 2.0.8 > Reporter: Tilman Hausherr > Priority: Major > Attachments: pdfbox-screenshot-bad.png, pdfbox-screenshot-good.png > > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org