thanks for the review - commited in r1827338 - simply forgot to replace the parameter with the new one :-( > Am 20.03.2018 um 17:46 schrieb Andreas Lehmkuehler <[email protected]>: > > On 03/20/2018 05:23 PM, Tilman Hausherr wrote: >> Am 20.03.2018 um 15:45 schrieb [email protected]: >>> - gid = doLookup(lookupTable, gid); >>> + lookupResult = doLookup(lookupTable, gid); >> I think that this changes the meaning. Because now gid is the original >> parameter, before the change gid was the current variable due to overwriting. > I guess all occurences of gid have to be replaced, like the following: > > lookupResult = doLookup(lookupTable, lookupResult); > > > Andreas >> Tilman >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
