[ https://issues.apache.org/jira/browse/PDFBOX-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416029#comment-16416029 ]
Maruan Sahyoun commented on PDFBOX-4158: ---------------------------------------- [~gary.potagal] with the refactoring avoiding double code and making the closing more readable that should be it from my perspective. Let me know what you think. Many thanks for your patch. > COSDocument and PDFMerger may not close all IO resources if closing of one > fails > -------------------------------------------------------------------------------- > > Key: PDFBOX-4158 > URL: https://issues.apache.org/jira/browse/PDFBOX-4158 > Project: PDFBox > Issue Type: Bug > Components: PDModel > Affects Versions: 2.0.4, 2.0.9, 3.0.0 PDFBox > Reporter: Maruan Sahyoun > Assignee: Maruan Sahyoun > Priority: Minor > Fix For: 2.0.10, 3.0.0 PDFBox > > Attachments: BiggestObjectAllocationGraph.png, BiggestObjectList.png, > PDFBOX-4158.patch > > > As observed on the users mailing list {{COSDocument.close}} and > {{PDFMergerUtility.mergeDocuments}} might not close all IO resources if > closing of one of the resources fails -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org