[
https://issues.apache.org/jira/browse/PDFBOX-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682776#comment-16682776
]
Tilman Hausherr commented on PDFBOX-4375:
-----------------------------------------
I agree with the renaming, but the line
{code:java}
specificPageOverlay.put(e.getKey(), doc);{code}
was removed by me on purpose, because that map is just to make sure that the
documents get closed. However because in the new method documents are passed,
these should be closed by the caller. Did you have any troubles without that
line or did you make that change because it looked as it had been forgotten?
> Change visibility of Overlay#loadPDF to protected
> -------------------------------------------------
>
> Key: PDFBOX-4375
> URL: https://issues.apache.org/jira/browse/PDFBOX-4375
> Project: PDFBox
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 2.0.12
> Reporter: Wiktor Kwapisiewicz
> Priority: Minor
> Labels: Overlay
> Attachments:
> 0001-Change-visibility-of-Overlay-loadPDF-to-protected.patch
>
>
> Overriding loadPDF allows subclasses to load overlays from sources different
> than File objects, for example from InputStreams or byte arrays (mostly
> through PDDocument.load overloads).
> For example:
> {code:java}
> Overlay overlay = new Overlay() {
> @Override
> protected PDDocument loadPDF(String pdfName) throws IOException {
> return PDDocument.load(overlayStreams.get(pdfName));
> }
> };
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
