[
https://issues.apache.org/jira/browse/PDFBOX-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683434#comment-16683434
]
ASF GitHub Bot commented on PDFBOX-4373:
----------------------------------------
GitHub user JohnBergqvist opened a pull request:
https://github.com/apache/pdfbox/pull/58
PDFBOX-4373: Add additional unit tests
Hi,
I ran JaCoCo over the `pdfbox` module, and found a few functions that were
missing unit test coverage.
I've written some tests for these functions, with the help of
[Diffblue](http://www.diffblue.com)
[Cover](https://www.diffblue.com/s/Diffblue-Cover-Datasheet.pdf).
Hopefully these tests should help you detect regressions caused by future
code changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Diffblue-benchmarks/Apache-PDFBox
additional-unit-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/pdfbox/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 40221ed013295771978886cea3f567eb3fb7cf33
Author: John Bergqvist <john.bergqvist@...>
Date: 2018-11-09T09:33:19Z
Add unit tests for org.apache.pdfbox.cos.COSObjectKey
These tests were written by Diffblue Cover.
commit b56e54f67903cbc2cf016929ed42b5875364c34b
Author: John Bergqvist <john.bergqvist@...>
Date: 2018-11-09T09:38:56Z
Add unit tests for org.apache.pdfbox.pdfwriter.COSWriterXRefEntry
These tests were written by Diffblue Cover.
commit 61c31c356f4b99ecf5e50d39a3d93aaee2d3789a
Author: John Bergqvist <john.bergqvist@...>
Date: 2018-11-09T09:52:13Z
Add unit tests for pdfbox.pdmodel.graphics.state.RenderingIntent
These tests were written by Diffblue Cover.
commit c1dc11beaaf048b8c58b340621fbb315bbe0b8ff
Author: John Bergqvist <john.bergqvist@...>
Date: 2018-11-09T10:00:13Z
Add unit tests for org.apache.pdfbox.pdmodel.PageLayout
These tests were written by Diffblue Cover.
commit 13293cb68762d0de5f10f63b6301de8eeaa976c3
Author: John Bergqvist <john.bergqvist@...>
Date: 2018-11-09T11:10:38Z
Add unit tests for org.apache.pdfbox.pdmodel.PageMode
These tests were written by Diffblue Cover.
----
> Add additional unit tests
> -------------------------
>
> Key: PDFBOX-4373
> URL: https://issues.apache.org/jira/browse/PDFBOX-4373
> Project: PDFBox
> Issue Type: Test
> Components: PDModel, Rendering, Writing
> Reporter: John Bergqvist
> Priority: Minor
>
> I've ran JaCoCo over the {{pdfbox}} module, and found some functions that
> were missing unit test coverage.
> I've written some unit tests for these functions and I would like to submit
> them.
> The functions I've written tests for are:
> * org.apache.pdfbox.cos.COSObjectKey.compareToInput
> * org.apache.pdfbox.pdfwriter.COSWriterXRefEntry.compareToInput
> * org.apache.pdfbox.pdmodel.PageLayout.fromString
> * org.apache.pdfbox.pdmodel.PageMode.fromString
> * org.apache.pdfbox.pdmodel.PageMode.stringValue
> * org.apache.pdfbox.pdmodel.graphics.state.RenderingIntent.fromString
> * org.apache.pdfbox.pdmodel.graphics.state.RenderingIntent.stringValue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
