[
https://issues.apache.org/jira/browse/PDFBOX-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803316#comment-16803316
]
Stefan Ziel edited comment on PDFBOX-4496 at 3/27/19 8:18 PM:
--------------------------------------------------------------
PDFBOX-4103 adds the consistent call
{code:java}
setGroupEnabled(PDOptionalContentGroup, boolean)
{code}
but it did not correct the inconsistent
{code:java}
setGroupEnabled(String, boolean)
{code}
that is what this patch tries to do ... but may be it would be better to remove
them at all. I lost some hours debugging my code that called
setGroupEnabled("de", false) and nothing visible happened ...
was (Author: jjcool):
PDFBOX-4103 adds the consistent call
{code:java}
setGroupEnabled(PDOptionalContentGroup, boolean)
{code}
but it did not correct the inconsistent
{code:java}
setGroupEnabled(String, boolean)
{code}
that is what this patch tries to do ...
> OCG enablement with string parameter is not well defined
> --------------------------------------------------------
>
> Key: PDFBOX-4496
> URL: https://issues.apache.org/jira/browse/PDFBOX-4496
> Project: PDFBox
> Issue Type: Bug
> Affects Versions: 2.0.14
> Reporter: Stefan Ziel
> Priority: Major
> Labels: OCGs
> Attachments: PDFBOX-4496.patch, original.pdf
>
>
> The class {noformat}
> org.apache.pdfbox.pdmodel.graphics.optionalcontent.PDOptionalContentProperties
> {noformat}
> contains two methods
> {noformat} setGroupEnabled(String, boolean){noformat} and {noformat}
> isGroupEnabled(String){noformat}
> accessing the OCG's state using a name as parameter.
> As there can exist various OCG with the same name this access is not well
> defined.
> The current implementation accesses the first group with this name it can
> find.
> To make the setter work a solution would be a loop over all groups with the
> given name and add them to ON or OFF. Consider to rename it to
> {noformat}setGroupsEnabledByName{noformat}
> The getter should return some error state if the groups diverge in state - or
> better drop it ...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
