[
https://issues.apache.org/jira/browse/PDFBOX-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805323#comment-16805323
]
Tilman Hausherr commented on PDFBOX-4496:
-----------------------------------------
Thanks, I'm fine with that change. The new contract corrects the old one.
I also had a closer look at your file. Of all the OCGs with "fi", only object
20 is used. So this is not really a good file, but I agree that an average user
sees "fi" on Adobe Reader and will want to have it active by using that name.
I am preparing an additional rendering test.
> OCG enablement with string parameter is not well defined
> --------------------------------------------------------
>
> Key: PDFBOX-4496
> URL: https://issues.apache.org/jira/browse/PDFBOX-4496
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
> Affects Versions: 2.0.14
> Reporter: Stefan Ziel
> Priority: Major
> Labels: OCGs
> Fix For: 2.0.15, 3.0.0 PDFBox
>
> Attachments: PDFBOX-4496.patch, original.pdf
>
>
> The class {noformat}
> org.apache.pdfbox.pdmodel.graphics.optionalcontent.PDOptionalContentProperties
> {noformat}
> contains two methods
> {noformat} setGroupEnabled(String, boolean){noformat} and {noformat}
> isGroupEnabled(String){noformat}
> accessing the OCG's state using a name as parameter.
> As there can exist various OCG with the same name this access is not well
> defined.
> The current implementation accesses the first group with this name it can
> find.
> To make the setter work a solution would be a loop over all groups with the
> given name and add them to ON or OFF. Consider to rename it to
> {noformat}setGroupsEnabledByName{noformat}
> The getter should return some error state if the groups diverge in state - or
> better drop it ...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
