[ 
https://issues.apache.org/jira/browse/PDFBOX-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810914#comment-16810914
 ] 

Tilman Hausherr commented on PDFBOX-45:
---------------------------------------

I finally got the build tests working this morning. The reason were the 
indirect objects (fixed for future developers if we ever decide to make arrays 
indirect, but has no effect on current versions), and a flaw in the reverted 
commit - the COSWriter segment that checks whether {{ByteRange}} is hit must 
move to the new segment in that same method.

I have decided not to commit my reverted change again because of the 
inefficient files. It makes sense to have arrays as direct objects, array 
elements are usually numbers or object references.

What I will also do is to change the parameter to a {{COSDictionary}} set. If 
somebody really wants to update another type, then the parent dictionary must 
be passed.

TODO after that: some test that fails with the 1 parameter method but succeeds 
with the 2 parameter method (objectsToWrite).


> Support incremental save
> ------------------------
>
>                 Key: PDFBOX-45
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-45
>             Project: PDFBox
>          Issue Type: New Feature
>          Components: Writing
>             Fix For: 3.0.0 PDFBox
>
>         Attachments: XFAFormFiller.java, fontbox-3.0.0-SNAPSHOT.jar, 
> fontbox-3.0.0-SNAPSHOT.jar, pdfbox-3.0.0-SNAPSHOT.jar
>
>
> [imported from SourceForge]
> http://sourceforge.net/tracker/index.php?group_id=78314&atid=552835&aid=1157431
> Originally submitted by purplish_cat on 2005-03-05 12:28.
> After opening a PDF file and changing objects out of it, 
> allow to save the changes incrementally to the same file 
> instead of creating a completely new file.
> [comment on SourceForge]
> Originally sent by benlitchfield.
> Logged In: YES 
> user_id=601708
> See forum thread at
> https://sourceforge.net/forum/message.php?msg_id=3032112



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to