[ 
https://issues.apache.org/jira/browse/PDFBOX-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851931#comment-16851931
 ] 

Tilman Hausherr commented on PDFBOX-4554:
-----------------------------------------

Yes I get that - you don't have it because you made that change from the patch. 
But my argument is that you don't need it - just pass the byte array without 
offset and length and your code will work the same. You mention "I have 
eliminated the fis.toByteArray now as well" - but it is still in your patch. Or 
do you have a second patch?

> operations taking a byte[] need to allow for offset and length too
> ------------------------------------------------------------------
>
>                 Key: PDFBOX-4554
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4554
>             Project: PDFBox
>          Issue Type: Improvement
>            Reporter: Jason Pyeron
>            Priority: Major
>
> Without this, massive amounts of memory must be copied/allocated to "trim" 
> byte[].
> See forthcoming pull request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to