[ 
https://issues.apache.org/jira/browse/PDFBOX-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861199#comment-16861199
 ] 

Tilman Hausherr commented on PDFBOX-4566:
-----------------------------------------

Nice refactoring! Sadly the Bavaria tests fail:
{noformat}
TestIsartorBavaria.validate:219 2002_28.pdf : PDF/A file should be valid, but 
has error: 1.2.12
TestIsartorBavaria.validate:219 ABNTNBR5298_1973.pdf : PDF/A file should be 
valid, but has error: 1.2.12
TestIsartorBavaria.validate:219 bley.pdf : PDF/A file should be valid, but has 
error: 1.2.12
TestIsartorBavaria.validate:274 validierung_von_pdfa.pdf : Invalid error code 
returned. Expected [3.1.4, 1.4.9, 2.2.1], found [3.1.4, 1.4.9]
TestIsartorBavaria.validate:224 pdfa_article_v11.pdf : PDF/A file should be 
invalid (expected [2.2.1])
{noformat}
You can enable them with -Dskip-bavaria=false . IIRC I disabled them by default 
because the ZIP file is no longer available from the original URL, and I don't 
want to put too much traffic on archive.org. I think I was also the one who 
disabled them on the build server, but can't remember why. Maybe some https 
problem.

In {{PreflightStreamEngine.validateInlineImageFilter}} thr replacement of 
{{dict.getDictionaryObject(COSName.F, COSName.FILTER);}} with 
{{dict.getCOSName(COSName.F, COSName.FILTER);}} - that's not the same, the 2nd 
parameter in the first call is an alternative, in the second call it's the 
default value.

In {{SinglePageValidationProcess.validateGroupTransparency}} the constant on 
line 238 should be {{COSName.TRANSPARENCY}}.

There's also a javadoc error in 
ExtGStateValidationProcess.extractExtGStateDictionaries(). 

> Remove COSUtils from preflight
> ------------------------------
>
>                 Key: PDFBOX-4566
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4566
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Preflight
>    Affects Versions: 3.0.0 PDFBox
>            Reporter: Andreas Lehmkühler
>            Assignee: Andreas Lehmkühler
>            Priority: Major
>             Fix For: 3.0.0 PDFBox
>
>
> The calls of the utility class {{org.apache.pdfbox.preflight.utils.COSUtils}} 
> isn't needed in most cases, so that we should remove it to get more 
> transparency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to