[ 
https://issues.apache.org/jira/browse/PDFBOX-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949174#comment-16949174
 ] 

Tilman Hausherr commented on PDFBOX-4667:
-----------------------------------------

I think I now understand it: 1) it is -1 which doesn't seem OK considering that 
DTL has 0, 2) -1 means "not initialized" on our system (because {{version}} is 
0 in OS2WindowsMetricsTable.java) but isn't treated as such. Test code:
{code}
TrueTypeFont ttf = new TTFParser().parse(new 
URL("https://issues.apache.org/jira/secure/attachment/12982682/OcrB%20Regular.ttf";).openStream());
System.out.println(ttf.getOS2Windows().getCodePageRange1());
System.out.println(ttf.getOS2Windows().getCodePageRange2());
{code}
So the correct thing would rather be to {{return false}} if 
{{info.getCodePageRange()}} returns -1. Or to to use 0 as "uninitialized" value.

> Issue in FontMapperImpl#isCharSetMatch when font codePageRange is -1
> --------------------------------------------------------------------
>
>                 Key: PDFBOX-4667
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4667
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 2.0.16
>            Reporter: Struve Pierre
>            Priority: Trivial
>         Attachments: OcrB Regular.ttf, screenshot-1.png
>
>
> Hi I met an issue with a font.
> It seems to me that code page range has not been set and then in 
> org.apache.pdfbox.pdmodel.font.FontMapperImpl#isCharSetMatch -1 is used.
> It seems to me that -1 means "open bar".
> I was trying to find a font that matches CHINESE_SIMPLIFIED 
> (cidSystemInfo.getOrdering{color:#9876aa}(){color}.equals{color:#9876aa}({color}{color:#6a8759}"GB1"{color}{color:#9876aa}){color}),
>  and due to the -1 this font was matched and unluckily it was the one picked.
> Do you think we can make a special case for -1 (return false)?
> Is there any font currently that matches all code page ranges?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to