[
https://issues.apache.org/jira/browse/PDFBOX-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008879#comment-17008879
]
Maruan Sahyoun edited comment on PDFBOX-4723 at 1/6/20 2:05 PM:
----------------------------------------------------------------
[~mkl] thnaks for taking a look.
Before going into details I have to say that I'm not a big fan of COSArrayList
at all. And also I do like the approach of COS and PD tp some extend it would
IMHO be much better to have them decoupled. So one would either work on PD or
COS level. It#s too easy to get them out of snc if you force it to.
Now to your point.
Not sure I got your point about {{removeAl}} - if I'm not mistaken it works
similar to a standard removeAll for a List. i.e. if there is a list entry with
3 identical objects and you call removeAll with one of the objetcs in the
Collection argument all entries are gone. So the current implementation does
just this but also for the backed COS array.
was (Author: msahyoun):
[~mkl] thnaks for taking a look.
Before going into details I have to say that I'm not a big fan of COSArrayList
at all. And also I do like the approach of COS and PD tp some extend it would
IMHO be much better to have them decoupled. So one would either work on PD or
COS level. It#s too easy to get them out of snc if you force it to.
Now to your point.
Not sure I got your point about {{removeAl}} - if I'm not miskaten it works
similar to a standard removeAll for a List. i.e. if there is a list entry with
3 identical objects and you call removeAll with one of the objetcs in the
Collection argument all entries are gone. So the current implementation does
just this but also for the backed COS array.
> Add equals() and hashCode() to PDAnnotation and COS objects
> -----------------------------------------------------------
>
> Key: PDFBOX-4723
> URL: https://issues.apache.org/jira/browse/PDFBOX-4723
> Project: PDFBox
> Issue Type: Sub-task
> Components: PDModel
> Affects Versions: 2.0.18
> Reporter: Maruan Sahyoun
> Assignee: Maruan Sahyoun
> Priority: Major
> Fix For: 2.0.19, 3.0.0 PDFBox
>
>
> In order to proper support removeAll/retainAll for COSArrayList we need to
> detect if entries are in fact duplicates of others. This currently fails as
> even though one might add the same instance of an annotation object multiple
> times to setAnnotations getting the annotations will have individual
> instances. See the discussion at PDFBOX-4669.
> In order to proper support removal we need to be able to detect equality
> where an object is equal if the underlying COSDictionary has the same entries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
