[ 
https://issues.apache.org/jira/browse/PDFBOX-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114898#comment-17114898
 ] 

Tilman Hausherr edited comment on PDFBOX-4840 at 5/23/20, 5:20 PM:
-------------------------------------------------------------------

Your change doesn't work, it fails when using rot0.pdf as base file and 
background.pdf as overlay file. (but works with the old code)

Also, with "diff / patch" I mean a file that shows the differences only. I'm 
not refusing the patch (I did the diff myself), and it is something that you 
should learn because it is useful with many projects. This is some feature that 
is likely in your IDE. You also need to work with the trunk, see here  
https://pdfbox.apache.org/building.html


was (Author: tilman):
Your change doesn't work, it fails when using rot0.pdf as base file and 
background.pdf as overlay file.

> Overlay doesn't work properly when page is rotated
> --------------------------------------------------
>
>                 Key: PDFBOX-4840
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4840
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.0.19
>            Reporter: Tilman Hausherr
>            Priority: Major
>         Attachments: Overlay.java, changes.png, rot0.pdf, rot180.pdf, 
> rot270.pdf, rot90.pdf
>
>
> Reverse of PDFBOX-4596, when the base page is rotated but not the overlay. 
> Whatever needs to be done will probably be inĀ {{calculateAffineTransform()}} 
> or in {{createOverlayXObject()}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to