[ 
https://issues.apache.org/jira/browse/PDFBOX-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133132#comment-17133132
 ] 

Alfred edited comment on PDFBOX-4877 at 6/11/20, 10:34 AM:
-----------------------------------------------------------

I have reverted all changes that were just because of formatting.

here's the patch again: [^PDFBOX-4877.patch]

and the new review: [https://diffy.org/diff/4swrv40dt4d7iy5ekoijh8h0k9]

I will delete the original patch and close the first review.

 

Forgot to mention that all tests pass.


was (Author: faltiska):
I have reverted all changes that were just because of formatting.

here's the patch again: [^PDFBOX-4877.patch]

and the new review: [https://diffy.org/diff/4swrv40dt4d7iy5ekoijh8h0k9]

I will delete the original patch and close the first review.

 

> Matrix class performance improvements
> -------------------------------------
>
>                 Key: PDFBOX-4877
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4877
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Parsing, Text extraction
>    Affects Versions: 2.0.20, 3.0.0 PDFBox
>            Reporter: Alfred
>            Assignee: Andreas Lehmkühler
>            Priority: Major
>              Labels: Optimization
>         Attachments: PDFBOX-4877.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> I am testing text extraction from PDF and profiling the execution.
> I found that the third major time consumer is with matrix multiplicaitons.
> The Matrix class spends large amounts of time copying results to new 
> instances. 
> Also, the if statements are slowing down execution as they kill performance 
> in modern CPUs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to