[
https://issues.apache.org/jira/browse/PDFBOX-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246015#comment-17246015
]
Maruan Sahyoun edited comment on PDFBOX-4723 at 12/8/20, 5:26 PM:
------------------------------------------------------------------
[~lehmi] I've missed to remove it - which I've done. What might make sense if
we want to ensure that we do an identity comparison is that we overwrite equals
and hashCode but do an identity check within so that the behaviour is not
implicity (as inherited from Object) - and document that properly.
was (Author: msahyoun):
[~lehmi] I've missed to remove it - which I've done. What might make sense if
we want to ensure that we do an identity comparison is that we overwrite equals
and hashCode but do an identity check within so that the behaviour is not
implicity (as inherited from Object).
> Add equals() and hashCode() to COS objects
> ------------------------------------------
>
> Key: PDFBOX-4723
> URL: https://issues.apache.org/jira/browse/PDFBOX-4723
> Project: PDFBox
> Issue Type: Sub-task
> Components: PDModel
> Affects Versions: 2.0.18
> Reporter: Maruan Sahyoun
> Assignee: Maruan Sahyoun
> Priority: Major
> Fix For: 3.0.0 PDFBox
>
> Attachments: bird_burst.heic.pdf, image-2020-09-02-13-52-21-370.png,
> image-2020-09-02-13-53-02-622.png, image-2020-09-02-13-54-31-630.png,
> screenshot-1.png
>
>
> In order to proper support removeAll/retainAll for COSArrayList we need to
> detect if entries are in fact duplicates of others. This currently fails as
> even though one might add the same instance of an annotation object multiple
> times to setAnnotations getting the annotations will have individual
> instances. See the discussion at PDFBOX-4669.
> In order to proper support removal we need to be able to detect equality
> where an object is equal if the underlying COSDictionary has the same entries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
