[ 
https://issues.apache.org/jira/browse/PDFBOX-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300579#comment-17300579
 ] 

Tilman Hausherr edited comment on PDFBOX-5127 at 3/12/21, 7:50 PM:
-------------------------------------------------------------------

Thanks for the explanation!
So either we synchronize access to the {{NumberFormatException}} segment (which 
will make it slower), or we generate SimpleDateFormat objects when needed 
(which will make it slower).


was (Author: tilman):
Thanks for the explanation!
So either we synchronize access to this segment (which will make it slower), or 
we generate SimpleDateFormat objects when needed (which will make it slower).

> Multithreading issue in JempBox's DateConverter
> -----------------------------------------------
>
>                 Key: PDFBOX-5127
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5127
>             Project: PDFBox
>          Issue Type: Bug
>            Reporter: Tim Allison
>            Priority: Major
>
> [~tilman] recently found an exception thrown from here 
> ([https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L186)]
>  in one run of tika-eval but not in another. 
>  
> This is a multithreading issue caused by 
> [https://github.com/apache/pdfbox/blob/1.8/jempbox/src/main/java/org/apache/jempbox/impl/DateConverter.java#L43]
>  SimpleDateFormat is not threadsafe.  I'm surprised we haven't seen this 
> earlier, but so it goes.
>  
> Many, many thanks to Tilman for finding this!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to