[ 
https://issues.apache.org/jira/browse/PDFBOX-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304339#comment-17304339
 ] 

Tilman Hausherr edited comment on PDFBOX-5134 at 3/18/21, 6:36 PM:
-------------------------------------------------------------------

Thanks, I tested this, and hit a few minor problems:
- context.getBounds() can be null
- PDTriangleBasedShadingType is also types 6 and 7, which do not produce a 
GouraudShadingContext
 Sadly types 6 and 7 are derived from type 4, so for the test I checked the 
class name like this \{{shading.getClass().getName().endsWith("4") || 
shading.getClass().getName().endsWith("5")}}.
- in one case, the context is a SoftMask

I avoided all these and all renderings are fine!

Another problem is making stuff public. We usually try to avoid that, because 
the more there is public, the more there is a risk of people using the API in 
weird ways that we haven't thought about.


was (Author: tilman):
Thanks, I tested this, and hit a few minor problems:
- context.getBounds() can be null
- PDTriangleBasedShadingType is also types 6 and 7, which do not produce a 
GouraudShadingContext
 Sadly types 6 and 7 are derived from type 4, so for the test I checked the 
class name like this \{{shading.getClass().getName().endsWith("4") || 
shading.getClass().getName().endsWith("5")}}.
- in one case, the context is a SoftMask
I avoided all these and all renderings are fine!

Another problem is making stuff public. We usually try to avoid that, because 
the more there is public, the more there is a risk of people using the API in 
weird ways that we haven't thought about.

> Very slow rendering on PageDrawer.shadingFill
> ---------------------------------------------
>
>                 Key: PDFBOX-5134
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5134
>             Project: PDFBox
>          Issue Type: Bug
>            Reporter: Oliver Schmidtmer
>            Priority: Major
>              Labels: shading
>         Attachments: Plan zum Testen.pdf, image-2021-03-17-20-16-49-221.png
>
>
> The PDF contains many effectively very small shadings, the light cones. As 
> the gradient painting for each light cone is applied on the whole image, 
> rendering is very slow: 29 of 33 seconds are spent in shadingFill.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to