valerybokov opened a new pull request #112: URL: https://github.com/apache/pdfbox/pull/112
Hi! I found TODO in CFFCharsetCID class and decided to implement it. Hope you find this helpful. Several notes: - I created CFFCharsetCID and CFFCharsetType1 (new classes) as package private because CFFCharset is abstract. Also, I set them as non-abstract because Format0Charset is not abstract. But if you think they should be abstract, I will think about how to change it. - I extracted the EmbeddedCharset from CFFParser because it is big class. I don't like to use big inner classes and CFFParser has too many inner classes. But if you want you able to move it (make as inner). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
