[ 
https://issues.apache.org/jira/browse/PDFBOX-5143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312607#comment-17312607
 ] 

valery commented on PDFBOX-5143:
--------------------------------

Hi! I found TODO in CFFCharsetCID class and decided to implement it. Hope you 
find this helpful. Link: [https://github.com/apache/pdfbox/pull/112]

Additionally, my comments about CFFExpertCharset  and CFFExpertSubsetCharset:

1 CFFExpertCharset has static instance (singletone) but uses non static field 
(CFF_EXPERT_CHARSET_TABLE). Make field non static?
2 CFFExpertSubsetCharset has static instance (singletone) but uses non static 
field (CFF_EXPERT_SUBSET_CHARSET_TABLE). Make field non static?

> Refactor/Simplify CFF parsing
> -----------------------------
>
>                 Key: PDFBOX-5143
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5143
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: FontBox
>    Affects Versions: 3.0.0 PDFBox
>            Reporter: Andreas Lehmkühler
>            Assignee: Andreas Lehmkühler
>            Priority: Major
>
> The classes used for the parsing of CFF-based fonts have some room for 
> improvements w.r.t. the memory footprint, the complexity of the code and the 
> test coverage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to