valerybokov commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-835776179
> I fixed the checkbox thing, thanks. I don't understand what you mean with the Point2d thing. What I can tell: > > * it works fine (there are almost no public tests due to file copyright and slight differences with different jdks, but there are many rendering tests that I do locally) > * that package is extremely performance sensitive > * the Point2D class is partly used to put coordinates in a set ShadedTriangle.constructor. You are clonning an array but NOT the array values (Point2d). So will be several arrays with same instances of points. If programmer will decide change some point in an array (for example to change x-coord) then the point will be changed for all arrays. I not found using of setters of Point2d but it is potential problem. Point2d[]ar1 = ar2.clone(); system.out.print(ar1==ar2); //expecting false system.out.print(ar1[0]==ar2[0]);//expecting FALSE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
