[
https://issues.apache.org/jira/browse/PDFBOX-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376840#comment-17376840
]
robo commented on PDFBOX-5068:
------------------------------
I created a pull-request on Github. Feel free to comment if there is anything,
that should be changed.
Two additional notes:
* PDAcroFormFlattenTest::testFlatten was unstable. Sometimes the tests failed,
sometimes not. I had to remove the concurrent execution in order to make it
work. I assume that the concurrent execution was added due to performance
reasons. However, after removing it the tests were equally fast (at least when
I tested it and with my internet connectino). If this concurrent execution was
part of the test design or if there are any other issues, this should be
reverted.
* There were some merge conflicts, particularly in COSWriter::getObjectKey,
which probably have to be reviewed.
* I removed the EagerCOSWriterObjectStorage mentioned above and left one
single COSWriterObjectStorage, since all tests work.
> OutOfMemory while signing large documents - continued
> -----------------------------------------------------
>
> Key: PDFBOX-5068
> URL: https://issues.apache.org/jira/browse/PDFBOX-5068
> Project: PDFBox
> Issue Type: Improvement
> Components: Signing
> Affects Versions: 2.0.23
> Reporter: Ralf Hauser
> Assignee: Andreas Lehmkühler
> Priority: Major
> Attachments: RandomAccessReadBufferDiag.java, issue5068.patch,
> minimum.pdf
>
>
> Continuation of PDFBOX-2512
>
> in COSWriter.prepareIncrement(), for the test case
> cosDoc.getXrefTable().keySet() has size 5925. For each of thes keys,
> cosDoc.getObjectFromPool() gets an object that is not just referencing some
> part of the input document, but duplicates it (which is unavoidable in the
> case where they are decompressed with FlateFilter - albeit this could
> possibly be done "lazy")
> -Xmx20m 746/5925
> -Xmx25m 1615/5925
> -Xmx30m 2800/5925
> -Xmx40m 3872/5925
> -Xmx55m 5773/5925
> With 60m, it gets them all, but dies later with less telling
> java.lang.OutOfMemoryError: GC overhead limit exceeded
>
> This assumes the patch of PDFBOX-5067 already in place - or using
> CreateVisibleSignature2.java as starting point
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
