sschwieb commented on a change in pull request #127:
URL: https://github.com/apache/pdfbox/pull/127#discussion_r684561085
##########
File path:
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/state/PDGraphicsState.java
##########
@@ -39,7 +44,8 @@
public class PDGraphicsState implements Cloneable
{
private boolean isClippingPathDirty;
- private Area clippingPath;
+ private List<GeneralPath> clippingPaths = new ArrayList<>();
+ private Map<GeneralPath, Area> clippingCache = new IdentityHashMap<>();
Review comment:
I'm not sure is it too naive to have an unbound cache here, but it could
easily be improved/size-limited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
