Am 09.08.2021 um 02:59 schrieb Stephan Schwiebert:
Hello,
first of all, thanks for building and maintaining PdfBox! It's a really
great & helpful API, and the examples & tools it comes with are awesome as
well. Love it!
I bumped into a few small issues (such as the problem with the clipping
area discussed in https://github.com/apache/pdfbox/pull/127), and am
wondering what you prefer when it comes to contributions. Just opening a
PR? Discuss it on the mailing list, or create an issue & discuss it there?
Mainly asking because I don't want to produce unnecessary noise. :)
I'm somewhat busy but I'd first commit the two small optimizations you
had into your patch, so please merge these if github doesn't do that
automatically. This will make your patch smaller and easier to understand.
My current understanding is that you want to do these intersect
operations on the final device. (This means bigger SVG files, but I
guess that is OK for you)
I was kinda skeptical of the whole thing because you mentioned it was
for SVG output so I'd say it's your own problem. But then you mentioned
the two troublesome files so THAT got me interested 😆. I'm also
wondering whether "getCurrentClippingPath()" is called several times on
the same path - if yes, then the new solution would be slower. But it
seems not.
Unless somebody else does it first, when I have more time I'll work your
changes into my local version and do a test run with my 1000 test files.
I'd also like some javadoc for the new methods.
Tilman
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
