sschwieb commented on pull request #127: URL: https://github.com/apache/pdfbox/pull/127#issuecomment-898961574
> So your initial changes may have made it faster (if my previous comment is correct), but the change in transfer made it slower. Thus I'll commit your main change but not the improvement. Yes please, and apologies for not explaining well. I did not want to suggest the snippet in my [comment](https://github.com/apache/pdfbox/pull/127#issuecomment-894871845) as the new default, I just wanted to show how this _could_ be changed if the use case requires/allows it. > Thank you for your contribution. I'd like to do two more changes: > > pass only the graphics device in the transfer method to make the parameter list smaller > > use the Path2D abstract class instead of Path2D.Double on the left side of the assignments, and as list / map elements. Thanks, that both sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
