Tilman Hausherr created PDFBOX-5298:
---------------------------------------
Summary: unneeded / double code in PageExtractor
Key: PDFBOX-5298
URL: https://issues.apache.org/jira/browse/PDFBOX-5298
Project: PDFBox
Issue Type: Bug
Components: Utilities
Affects Versions: 2.0.24
Reporter: Tilman Hausherr
Assignee: Tilman Hausherr
Fix For: 2.0.25, 3.0.0 PDFBox
valerybokov mentioned this in PR 107:
{quote}
I found one strange detail in a PageExtractor class. An interesting process is
going on inside the extraction method. In the loop we calling the importPage
method. Inside this method we changing the cropbox, mediabox and rotation for
an imported page. We doeing the same in the PageExtractor.extract method. Maybe
you will remove unneeded initialisations of the cropbox etc. Also, the
importPage method notifies us about resources but we doeing right operation
with resources in the PageExtractor.extract method (inherited resources of
source document are not imported to...).
{quote}
I'll remove the calls and make the resource setting conditional as suggested in
ImportPage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]