valerybokov edited a comment on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-969903630
> > Hi, @THausherrI found one strange method. COSInteger.equals. Why it has no isValid method checks? > > Yeah maybe it should be done. But isValid is about big values that are outside of allowed range, so maybe they are equal to another value value in a different type, so maybe that is the reason it isn't checked. I dont know the range of these values. Can COSInteger be valid with max (or min) long value? If yes, IMHO, then we need isvalid check in the equals method. You are using the boolean field and long field. If max long and min long are valid you able to check to max and min values of the COSInteger instances (static fields). You will delete boolean field this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
