[ 
https://issues.apache.org/jira/browse/PDFBOX-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550228#comment-17550228
 ] 

Maruan Sahyoun commented on PDFBOX-5451:
----------------------------------------

I think cloning is the better option here although using more memory if you'd 
like to ensure that the COSString is not manipulated under the hood. 

> Avoid copying byte array for COSString
> --------------------------------------
>
>                 Key: PDFBOX-5451
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5451
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Parsing
>    Affects Versions: 3.0.0 PDFBox
>            Reporter: Andreas Lehmkühler
>            Assignee: Andreas Lehmkühler
>            Priority: Major
>             Fix For: 3.0.0 PDFBox
>
>
> When creating a COSString the given byte array is cloned. As in most cases 
> the array is just an intermediate object we should remove that to reduce the 
> memory footprint.
> Furthermore the {{getBytes}} returns the internal byte array so that I don't 
> see any reason not to use the given byte array itself instead of cloning it



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to