THausherr commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1186433593
> Hi, @THausherr! The few my observations: > 1 AnnotationBorder.underline - unused field. > 2 CCITTFactory.readshort - useless if-statement (wrong if body?). > 3 PDCaretAppearanceHandler - line 73. Operation result is ignored (matrix.transformPoint(rd, rd);) 1) true, but I'll keep it. This is because PDLinkAppearanceHandler doesn't use AnnotationBorder for some reason. Maybe it should, but this isn't really that important. From what I see, this would require more changes, some of them breaking. 2) I don't understand. TIFF files start with "II" or "MM". 3) thanks, removed. I have no idea why I did this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
