[
https://issues.apache.org/jira/browse/PDFBOX-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607906#comment-17607906
]
Michael Klink commented on PDFBOX-5513:
---------------------------------------
{quote}If we create a PageMode.UNSPECIFIED then what would be its value?{quote}
Most appropriately an attempt to retrieve its value should cause an exception.
Thus, this enumeration member would essentially shift the exception to a later
time.
Also an attempt to set the document page mode to PageMode.UNSPECIFIED should be
rejected.
Oh well, maybe not a good alternative after all...
{quote}I think this is now evolving into something complex.{quote}
Indeed, and that wasn't my intention at all. I just wanted to express that a
plain getter IMO should not return a value clearly different from the actual
value.
If the method name had indicated that some interpretation takes place (e.g.
{{interpretPageMode}} or {{getBestPageModeMatch}} or {{getEffectivePageMode}}),
I probably wouldn't have started such an argument at all ;). But as the method
with that name has been around for so many years, one also shouldn't rename it
on a whim.
> getPageLayout throws IllegalArgumentException for empty mode
> ------------------------------------------------------------
>
> Key: PDFBOX-5513
> URL: https://issues.apache.org/jira/browse/PDFBOX-5513
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
> Affects Versions: 2.0.25, 2.0.26, 3.0.0 PDFBox
> Reporter: Karol Bryd
> Assignee: Tilman Hausherr
> Priority: Major
> Fix For: 2.0.27, 3.0.0 PDFBox
>
> Attachments: page_layout_issue.patch
>
>
> getPageLayout() method in PDDocumentCatalog can throw an exception
> IllegalArgumentException when the PageLayout mode is not one of defined in
> the PageLayout class. In my case the mode is simply an empty string.The PDF
> documents which contain such unexpected Page Layout value are all rendered by
> quite old Adobe PDF library 7.0 from 2014 (I can't share the document, it is
> confidential....).
> My suggestion is to modify the method so that, similarly to getPageMode()
> method, the eventual exception is caught and the method returns the default
> PageLayout.{color:#9876aa}SINGLE_PAGE {color}mode.{color:#9876aa}
> {color}
>
> This problem affects the current version in trunk, as well as at least 2.0.25
> and 2.0.26.
>
> I have created very simple patch which fixes the problem, please consider
> applying it to the trunk and 2.0.x branch.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
