lehmi commented on code in PR #149:
URL: https://github.com/apache/pdfbox/pull/149#discussion_r1068971320
##########
pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFMergerUtility.java:
##########
@@ -1498,8 +1499,8 @@ private void updateStructParentEntries(PDPage page, int
structParentOffset) thro
List<PDAnnotation> newannots = new ArrayList<>(annots.size());
annots.forEach(annot ->
{
- int structParent = annot.getStructParent();
- if (structParent >= 0)
+ int structParent =
annot.getCOSObject().getInt(COSName.STRUCT_PARENT, Integer.MIN_VALUE); // allow
for negative struct parent values
Review Comment:
This doesn't change anything but the default value if STRUCT_PARENT is null.
If Integer.MIN_VALUE makes more sense than -1 the getter should be changed
rather than this piece of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
