[
https://issues.apache.org/jira/browse/PDFBOX-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719651#comment-17719651
]
ASF subversion and git services commented on PDFBOX-5594:
---------------------------------------------------------
Commit 1909621 from [email protected] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1909621 ]
PDFBOX-5594: remove the usage of RandomAccessReadBuffer from
RandomAccessReadDataStream so that it is save to remove the finalize override
from rueTypeFont
> Remove finalize from TrueTypeFont
> ---------------------------------
>
> Key: PDFBOX-5594
> URL: https://issues.apache.org/jira/browse/PDFBOX-5594
> Project: PDFBox
> Issue Type: Improvement
> Components: FontBox
> Affects Versions: 3.0.0 PDFBox
> Reporter: Andreas Lehmkühler
> Assignee: Andreas Lehmkühler
> Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> The usage of finalize is discouraged so that it is a good idea to remove it.
> I've found a way to do so for {{org.apache.fontbox.ttf.TrueTypeFont}}.
> All the data of a {{RandomAccessReadDataStream}} is copied to a final byte
> array. The additional {{RandomAccessReadBuffer}} isn't needed at all, so that
> it is save to do nothing when closing a {{RandomAccessReadDataStream}}. Now
> it is save to remove the finalize override from {{TrueTypeFont}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
