[ 
https://issues.apache.org/jira/browse/PDFBOX-5690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771136#comment-17771136
 ] 

Tilman Hausherr commented on PDFBOX-5690:
-----------------------------------------

Thanks I did all except findImageReader and computeInternalHash. Making that 
change would allow people extending these methods.

> Improve readability by using standard declaration syntax
> --------------------------------------------------------
>
>                 Key: PDFBOX-5690
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5690
>             Project: PDFBox
>          Issue Type: Improvement
>    Affects Versions: 4.0.0
>            Reporter: Axel Howind
>            Priority: Minor
>         Attachments: declaration_syntax.patch
>
>
> The PDFBox codebase in some places uses non standard or less common 
> declaration syntax, such as "final static" modifiers instead of "static 
> final". This should be cleaned up to make the code more readable.
> This patch changes the declarations to the standard form to make the codebase 
> more readable, and reduce the amount of issues displayed in your development 
> environment (if warnings for coding style are enabled). It might or might not 
> reduce issues reported by static analysis tools like Sonar or Qodana (depends 
> on configuration).
> This patch does not introduce any semantic changes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to