Hm… I just did a clean checkout of trunk and did mvn clean verify and 
everything passes, both with log4j2.version set to 2.20.0 and 2.21.0. I can 
however see file differences reported in the log like this:

[INFO] Running org.apache.pdfbox.pdmodel.interactive.form.PDAcroFormTest
Files differ: 
/Users/axelhowind/IdeaProjects/pdfbox/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/interactive/form/MultilineFields.pdf-1.png
              
/Users/axelhowind/IdeaProjects/pdfbox/pdfbox/target/test-output/MultilineFields.pdf-1.png
Rendering of target/test-output/MultilineFields.pdf failed or is not identical 
to expected rendering in 
src/test/resources/org/apache/pdfbox/pdmodel/interactive/form directory
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.027 s 
-- in org.apache.pdfbox.pdmodel.interactive.form.MultilineFieldsTest

But these are not reported as test failures. In the test code, I can see that 
this is by design:

// compare rendering
if (!TestPDFToImage.doTestFile(pdf, IN_DIR.getAbsolutePath(), 
OUT_DIR.getAbsolutePath()))
{
    // don't fail, rendering is different on different systems, result must be 
viewed manually
    System.err.println("Rendering of " + pdf + " failed or is not identical to 
expected rendering in " + IN_DIR + " directory");
}
What exactly does "it no longer works" mean? Is it related to the above, or is 
it the build failures reported by Jenkins on the list?

Axel

> Am 20.10.2023 um 06:50 schrieb axh <[email protected]>:
> 
> Hi,
> 
> just saw your message here. As I just started on replacing commons-logging by 
> log4j, I will also look into this. I also overlooked that there’s already a 
> property for the log4j version. Will update the patch I just submitted and 
> then see if I can find out what’s causing the test failure with 2.21.0.
> 
> Axel
> 
>> Am 19.10.2023 um 19:06 schrieb Tilman Hausherr <[email protected]>:
>> 
>> I have reverted the change to the log4j2 version. It no longer works. I'll 
>> wait a bit if there is an issue about it, there was nothing on the mailing 
>> list today.
>> 
>> Tilman
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 

Reply via email to