Vivek504 opened a new pull request, #171: URL: https://github.com/apache/pdfbox/pull/171
### Move Method Refactoring **Reason:** Feature Envy 1. readSimpleValue is more interested in members of the type: Type1Font 2. readFontInfo is more interested in members of the type: Type1Font 3. readPrivate is more interested in members of the type: Type1Font 4. readProc is more interested in members of the type: Type1Lexer 5. readProcVoid is more interested in members of the type: Type1Lexer 6. readMaybe is more interested in members of the type: Type1Lexer **Logic of Refactoring:** 1. For methods (readSimpleValue, readFontInfo and readPrivate), the code which is only dependent on Type1Font, that is moved to Type1Font class by creating a new method (readFontAttributes). 2. readProc, readProcVoid and readMaybe: these methods are removed from Type1Parser class and moved to Type1Lexer class as all 3 methods are only interested on the members of Type1Lexer class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
