[ 
https://issues.apache.org/jira/browse/PDFBOX-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792557#comment-17792557
 ] 

ASF subversion and git services commented on PDFBOX-5723:
---------------------------------------------------------

Commit 1914306 from le...@apache.org in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1914306 ]

PDFBOX-5723: remove already cached hashCode a proposed by Axel Howind

> COSName caches already cached hashCode
> --------------------------------------
>
>                 Key: PDFBOX-5723
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5723
>             Project: PDFBox
>          Issue Type: Bug
>    Affects Versions: 2.0.30, 3.0.1 PDFBox, 4.0.0
>            Reporter: Axel Howind
>            Assignee: Andreas Lehmkühler
>            Priority: Minor
>             Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>         Attachments: Remove_hashCode()_field_from_COSName.patch
>
>
> COSName stores a name (String) and a hash code (int), both are final. The 
> constructor calculates the hashCode as `hashCode = name.hashCode()`. Since 
> the String class itself also caches the hashCode (it is calculated at first 
> access), this is unnecessary and on most JVM implementations wastes 8 bytes 
> of memory per COSName instance (4 for the integer and another 4 for padding). 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to